sherlock-audit / 2024-03-arrakis-judging

0 stars 0 forks source link

NoOne - use `safeMint` instead `mint` #90

Closed sherlock-admin4 closed 1 month ago

sherlock-admin4 commented 1 month ago

NoOne

medium

use safeMint instead mint

Summary

In ArrakisMetaVaultFactory.sol function deployPrivateVault use mint instead safeMint

Vulnerability Detail

Impact

Using ERC721::_mint() can mint ERC721 tokens to addresses which don't support ERC721 tokens, while ERC721::_safeMint() ensures that ERC721 tokens are only minted to addresses which support them.

Code Snippet

https://github.com/sherlock-audit/2024-03-arrakis/blob/main/arrakis-modular/src/ArrakisMetaVaultFactory.sol#L245

Tool used

Manual Review

Recommendation

use safeMint instead mint