search

sherlock-audit / 2024-03-zivoe-judging

8 stars 6 forks source link

BoRonGod - curve pool's emergency_admin can kill a curve pool #677

Closed sherlock-admin4 closed 6 months ago

sherlock-admin4 commented 6 months ago

BoRonGod

medium

curve pool's emergency_admin can kill a curve pool

Summary

curve pool's emergency_admin action can lead to the fund of Zivoe protocol and its users being stuck, resulting in DAO being unable to push/pull assets from OCY_Convex_C and OCY_Convex_A.

Vulnerability Detail

Per the contest page, the admins of the protocols that Zivoe integrates with are considered "RESTRICTED". This means that any issue related to curve pool's emergency_admin action that could negatively affect Zivoe protocol/users will be considered valid in this audit contest.

Q: Are the admins of the protocols your contracts integrate with (if any) TRUSTED or RESTRICTED?

RESTRICTED

AND:

Q: In case of external protocol integrations, are the risks of external contracts pausing or executing an emergency withdrawal acceptable? If not, Watsons will submit issues related to these situations that can harm your protocol's functionality.

Not acceptable

Currently, curve pool's emergency_admin can force kill a curve pool.

According to curve doc:

Pool and Gauge proxies usually have three different admins (representing the different agents of curve):

ownership_admin: controls most functionality; requires a 30% quorum with 51% support parameter_admin: authority to modify parameters on pools; requries a 15% quorum with 60% support emergency_admin: limited authority to kill pools and gauges under certain circumstances

Once a pool is killed, zivoe DAO can no longer push/pull tokens from that OCY_Convex.

Impact

Once a pool is killed, all the fund of Zivoe protocol and its users put in it will be stuck, resulting in users being unable to withdraw their assets.

Code Snippet

https://docs.curve.fi/curve_dao/ownership-proxy/overview/?h=emergency#curve-dao-protocol-ownership https://etherscan.io/address/0xb30da2376f63de30b42dc055c93fa474f31330a5#code

Tool used

Manual Review

Recommendation

Ensure that the protocol team and its users are aware of the risks of such an event and develop a contingency plan to manage it.

Duplicate of #657

pseudonaut commented 6 months ago

I suppose valid, not of concern

sherlock-admin2 commented 6 months ago

1 comment(s) were left on this issue during the judging contest.

panprog commented:

invalid, there is nothing can be done in such case, so it's just informational issue