There are some function which do not include the whenNotPaused modifier.
Vulnerability Detail
There are several functions, including TellerV2::cancelBid , TellerV2::marketOwnerCancelBid, TellerV2::repayLoanMinimum, TellerV2::repayLoanFull that lack the whenNotPaused modifier.
Impact
This can lead to a borrower being able to cancel their bid even when the protocol is paused and all operations must be temporarily paused.
Invalid, there is no exploit here even if this functions are allowed to be executed since users are still choosing to perform the actions. Any other reasons will simply be speculation.
MaslarovK.eth
medium
Some functions lack
whenNotPaused
modifier.Summary
There are some function which do not include the
whenNotPaused
modifier.Vulnerability Detail
There are several functions, including
TellerV2::cancelBid
,TellerV2::marketOwnerCancelBid
,TellerV2::repayLoanMinimum
,TellerV2::repayLoanFull
that lack thewhenNotPaused
modifier.Impact
This can lead to a borrower being able to cancel their bid even when the protocol is paused and all operations must be temporarily paused.
Code Snippet
https://github.com/sherlock-audit/2024-04-teller-finance/blob/main/teller-protocol-v2-audit-2024/packages/contracts/contracts/TellerV2.sol#L428-L459
etc.
Tool used
Manual Review
Recommendation
Implement the following changes to all the functions that lack the modifier: