Closed sherlock-admin3 closed 2 months ago
SmartCommitmentsForwarder
Low/Info issue submitted by KiroBrejka
As CommitmentCollateralType is an enum, the collateral token type can't be <= CommitmentCollateralType.ERC1155_ANY_ID as it is right now
CommitmentCollateralType
CommitmentCollateralType.ERC1155_ANY_ID
https://github.com/sherlock-audit/2024-04-teller-finance/blob/main/teller-protocol-v2-audit-2024/packages/contracts/contracts/LenderCommitmentForwarder/SmartCommitmentForwarder.sol#L48-L53
Manual Review
Change the <= to !=
<=
!=
Bad collateral check in
SmartCommitmentsForwarderLow/Info issue submitted by KiroBrejka
Summary
Vulnerability Detail
As
CommitmentCollateralTypeis an enum, the collateral token type can't be <=CommitmentCollateralType.ERC1155_ANY_IDas it is right nowImpact
Code Snippet
https://github.com/sherlock-audit/2024-04-teller-finance/blob/main/teller-protocol-v2-audit-2024/packages/contracts/contracts/LenderCommitmentForwarder/SmartCommitmentForwarder.sol#L48-L53
Tool used
Manual Review
Recommendation
Change the
<=to!=