Edition referrer never receives any fee, which goes to the mint referrer instead
Summary
The protocol includes Edtion and mint referrers, which get a share of the protocol fee. However, there is a bug in FeeManager::_splitProtocolFee() that assigns the Edition referral fee to the mint referrer.
Vulnerability Detail
In a mint in Edition, FeeManager::collectMintFee() is called to collect fees for the creator, protocol, mint and Edition referrers. In FeeManager::_splitProtocolFee(), the fees are split between the protocol, Edition and mint referrers. As can be seen here, the Edition (collection) referral fee is assigned to the mint referrer, instead of referrers[edition_].
0x73696d616f
high
Edition
referrer never receives any fee, which goes to themint
referrer insteadSummary
The protocol includes
Edtion
andmint
referrers, which get a share of the protocol fee. However, there is a bug inFeeManager::_splitProtocolFee()
that assigns theEdition
referral fee to themint
referrer.Vulnerability Detail
In a mint in
Edition
,FeeManager::collectMintFee()
is called to collect fees for the creator, protocol, mint andEdition
referrers. In FeeManager::_splitProtocolFee(), the fees are split between the protocol,Edition
andmint
referrers. As can be seen here, theEdition
(collection) referral fee is assigned to themint
referrer, instead ofreferrers[edition_]
.Impact
Edition
(collection) referrers receive no fees.Code Snippet
Tool used
Manual Review
Vscode
Recommendation
Replace
referrer_
withreferrers[edition_]
.Duplicate of #267