search

sherlock-audit / 2024-04-titles-judging

9 stars 6 forks source link

AgileJune - Edition.sol::mintBatch(multi-tokens to one receiver) will always revert with non-existed function calling of ERC-1155. #237

Closed sherlock-admin4 closed 4 months ago

sherlock-admin4 commented 4 months ago

AgileJune

high

Edition.sol::mintBatch(multi-tokens to one receiver) will always revert with non-existed function calling of ERC-1155.

Summary

Edition.sol::mintBatch(multi-tokens to one receiver) will always revert with non-existed function calling of ERC-1155.

Vulnerability Detail

Edition.sol::mintBatch(multi-tokens to one receiver) is calling _batchMint function, but it's not in ERC1155 implementation. The exact function is _mintBatch.

Impact

mintBatch function will always revert.

Code Snippet

https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L295

Tool used

Manual Review

Recommendation

replace _batchMint with _mintBatch .