Closed sherlock-admin4 closed 4 months ago
@Hash01011122 isn't this a dup of https://github.com/sherlock-audit/2024-04-titles-judging/issues/269 ?
Escalate
dupe of #269
Escalate
dupe of #269
You've created a valid escalation!
To remove the escalation from consideration: Delete your comment.
You may delete or edit your escalation comment anytime before the 48-hour escalation window closes. After that, the escalation becomes final.
I agree with the escalation. This issue is a duplicate of #269.
Result: High Duplicate of #269
Dots
high
Edition.sol doesn't actually refunt excess ETH
Summary
Edition.sol
doesn't actually refunt excess ETH.Vulnerability Detail
When minting tokens, all of the ETH gets sent to the
FeeManager
contract, which would leave theEdition.sol
contract empty to begin with. So any excess ETH would actually get stuck in theFeeManager
contract.Impact
The user will not recieve his excess ETH back.
Code Snippet
https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L228-L242
https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L512-L516
Tool used
Manual Review
Recommendation
Think of a way to return the excess ETH from
FeeManager.sol
.Duplicate of #269