Closed sherlock-admin4 closed 4 months ago
@Hash01011122 isnt this a dup of https://github.com/sherlock-audit/2024-04-titles-judging/issues/264 ?
Escalate
This is a dupe of the valid issue #264
Escalate
This is a dupe of the valid issue #264
You've created a valid escalation!
To remove the escalation from consideration: Delete your comment.
You may delete or edit your escalation comment anytime before the 48-hour escalation window closes. After that, the escalation becomes final.
Agree with the escalation, planning to accept and duplicate with #264
Result: High Duplicate of #264
Dots
high
User can mint the same work multiple times for the price of one
Summary
User can mint the same work multiple times for the price of one.
Vulnerability Detail
When minting works with
mintBatch
function inEdition.sol
, theFEE_MANAGER.collectMintFee
uses theamount_
parameter as if we are going to mint that exact amount. However this is the amount of tokens that we are minting to each receiver, not the whole amount of tokens minted.Impact
Exploiting the protocol
Code Snippet
https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L304-L320
Tool used
Manual Review
Recommendation
I'd recommend multiplying the
amount_
byreceivers_.length
.Duplicate of #264