Closed sherlock-admin3 closed 4 months ago
This seems valid based on the Readme
Seems borderline low/medium
Escalate
Should be low as it does not have any impact. EIP712 issues are valid when it causes problems due to not being able to correctly sign signatures, but this is not the case here.
Escalate
Should be low as it does not have any impact. EIP712 issues are valid when it causes problems due to not being able to correctly sign signatures, but this is not the case here.
You've created a valid escalation!
To remove the escalation from consideration: Delete your comment.
You may delete or edit your escalation comment anytime before the 48-hour escalation window closes. After that, the escalation becomes final.
Agree with invalidation reason, looks like a feature request.
EIP712 does not define an interface contract or anything in the like, it is about hashing and signing typed structured data. This issue does not indicate any non-compliance with EIP712. It seems to be pointed that the contract does not inherit from an IEIP712
interface or the like, which is not a problem considering EIP712.
See https://eips.ethereum.org/EIPS/eip-712.
See also Solady's implementation of EIP712 which defines only one public function eip712Domain()
defined in EIP5267 and not EIP712: https://github.com/vectorized/solady/blob/main/src/utils/EIP712.sol
https://eips.ethereum.org/EIPS/eip-5267
Agree with the escalation. Planning to accept it and invalidate the issue, unless someone shows and proves how it effects external integrations.
Agree with the escalation this is indeed low
Result: Invalid Unique
xiaoming90
medium
EIP 712 is not implemented for the
Edition
contract.Summary
EIP 712 is not implemented for the
Edition
contract.Vulnerability Detail
The Contest's README stated that EIP 712 must be strictly implemented for the
Edition
contract. Thus, in the context of this audit contest, any non-compliance is considered a valid Medium issue. Note that the Contest's README supersedes Sherlock's judging rules per Sherlock's Hierarchy of truth.However, when reviewing the
Edition
contract, it was observed that EIP 712 is not implemented for theEdition
contract. Thus, breaking the above requirement.https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L36
Impact
EIP 712 is not implemented for the
Edition
contract.Code Snippet
https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L36
Tool used
Manual Review
Recommendation
Consider implementing EIP 712 for the
Edition
contract.