Closed sherlock-admin3 closed 2 months ago
Escalate
This finding is a valid dup of #264
Escalate
This finding is a valid dup of #264
You've created a valid escalation!
To remove the escalation from consideration: Delete your comment.
You may delete or edit your escalation comment anytime before the 48-hour escalation window closes. After that, the escalation becomes final.
Agree with the escalation, planning to accept and duplicate with #264
Result: High Duplicate of #264
ArsenLupin
high
The attacker could mint all the tokenId's, but paying the fee only for the 1 tokenId
Summary
In the mintBatch function we can mint a token to a set of receivers for the given work. However the function works incorrectly, because the fees is paid only for 1 tokenId, but the issue function mint tokenId in the loop to the different addresses.
Vulnerability Detail
Impact
Attacker could mint all the tokenId's to hisself(accounts that belongs to attacker) and prevent other user's from minting this tokenId
Code Snippet
https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L304-L320
Tool used
Manual Review / Foundry
Recommendation
Ensure that the correct amount of fees is paid, based on the overall amount of minted tokenId's.
Duplicate of #264