sherlock-audit / 2024-04-titles-judging

9 stars 6 forks source link

CodeWasp - `Edition.transferWork` does not update fee routes #389

Closed sherlock-admin4 closed 4 months ago

sherlock-admin4 commented 5 months ago

CodeWasp

high

`Edition.transferWork` does not update fee routes

Summary

Edition.transferWork does not update the work's fee route, keeps sending fee payments to initial creator.

Vulnerability Detail

Edition.transferWork changes the work's creator, but doesn't update the fee route in FeeManager.

Impact

Fee payments still go to the initial creator.

Code Snippet

https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/editions/Edition.sol#L412-L420

Tool used

Manual Review

Recommendation

Update fee route when work is transferred.

Duplicate of #283