Closed sherlock-admin3 closed 1 month ago
me_na0mi
medium
Protocol won't work on zkSync because of libraries incompatible with zkSync EVM.
Opcodes like create from LibClone Solady library that is called during clone call https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/TitlesCore.sol#L79 or create2 from Clone SplitFactory https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/fees/FeeManager.sol#L144. has different behaviour on zkSync chain - https://docs.zksync.io/build/developer-reference/differences-with-ethereum.html .
create
create2
Addresses will be calculated in different way and protocol will be broken.
Manual Review
Use compatible libraries that will work on zkSync instead.
Duplicate of #91
me_na0mi
medium
Protocol won't work on zkSync
Summary
Protocol won't work on zkSync because of libraries incompatible with zkSync EVM.
Vulnerability Detail
Opcodes like
createfrom LibClone Solady library that is called during clone call https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/TitlesCore.sol#L79 orcreate2from Clone SplitFactory https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/fees/FeeManager.sol#L144. has different behaviour on zkSync chain - https://docs.zksync.io/build/developer-reference/differences-with-ethereum.html .Impact
Addresses will be calculated in different way and protocol will be broken.
Code Snippet
Tool used
Manual Review
Recommendation
Use compatible libraries that will work on zkSync instead.
Duplicate of #91