sherlock-audit / 2024-04-titles-judging

9 stars 6 forks source link

CodeWasp - TitlesGraph does not save acknowledgement #452

Closed sherlock-admin3 closed 4 months ago

sherlock-admin3 commented 5 months ago

CodeWasp

medium

TitlesGraph does not save acknowledgement

Summary

TitlesGraph does not save acknowledgement

Vulnerability Detail

TitlesGraph._setAcknowledged does not save acknoweldgement

Impact

Contract state not reflecting user intent

Code Snippet

https://github.com/sherlock-audit/2024-04-titles/blob/main/wallflower-contract-v2/src/graph/TitlesGraph.sol#L200-L206

Tool used

Manual Review

Recommendation

Change return parameter Edge memory edge to storage

Duplicate of #212