Closed sherlock-admin3 closed 2 months ago
BeefyRewardPool
IRewardPool
Low/Info issue submitted by ccashwell
BeefyRewardPool.sol is an implementation of the IRewardPool interface, but does not inherit the interface. Informational only.
BeefyRewardPool.sol
The reward pool implementation does not reference the interface it intends to implement.
Low/Informational - no tangible impact
IRewardPool.sol
// SPDX-License-Identifier: MIT pragma solidity 0.8.23; interface IRewardPool { function notifyRewardAmount(address token, uint256 reward, uint256 duration) external; }
// ... contract BeefyRewardPool is ERC20Upgradeable, OwnableUpgradeable { // ... function notifyRewardAmount( address _reward, uint256 _amount, uint256 _duration ) external onlyManager update(address(0)) { // ...
Manual Review
Implement the interface or remove it.
BeefyRewardPool
should inherit fromIRewardPool
Low/Info issue submitted by ccashwell
Summary
BeefyRewardPool.sol
is an implementation of theIRewardPool
interface, but does not inherit the interface. Informational only.Vulnerability Detail
The reward pool implementation does not reference the interface it intends to implement.
Impact
Low/Informational - no tangible impact
Code Snippet
IRewardPool.sol
BeefyRewardPool.sol
Tool used
Manual Review
Recommendation
Implement the interface or remove it.