sherlock-audit / 2024-05-beefy-cowcentrated-liquidity-manager-judging

5 stars 5 forks source link

Misleading comment #137

Closed sherlock-admin4 closed 2 months ago

sherlock-admin4 commented 2 months ago

Misleading comment

Low/Info issue submitted by nikolap

Summary

The twap function doc string is misleading, it says it forms a twap from 60 seconds when it fact it forms it from 120. The number could very

Vulnerability Detail

Impact

Code Snippet

It's defined here as https://github.com/sherlock-audit/2024-05-beefy-cowcentrated-liquidity-manager/blob/42ef5f0eac1bc954e888cf5bfb85cbf24c08ec76/cowcentrated-contracts/contracts/strategies/velodrome/StrategyPassiveManagerVelodrome.sol#L185

but then it's used here and the function description misleads https://github.com/sherlock-audit/2024-05-beefy-cowcentrated-liquidity-manager/blob/42ef5f0eac1bc954e888cf5bfb85cbf24c08ec76/cowcentrated-contracts/contracts/strategies/velodrome/StrategyPassiveManagerVelodrome.sol#L743

Tool used

Manual Review

Recommendation