search

sherlock-audit / 2024-05-beefy-cowcentrated-liquidity-manager-judging

5 stars 5 forks source link

maxTickDeviation could be unset #143

Closed sherlock-admin4 closed 2 months ago

sherlock-admin4 commented 2 months ago

maxTickDeviation could be unset

Low/Info issue submitted by petarP1998

Summary

In the StrategyPassiveManagerVelodrome contract, the maxTickDeviation parameter is configurable through a designated setter function. However, if the contract owner neglects to set this parameter, it could lead to operational issues.

Vulnerability Detail

The maxTickDeviation parameter in the StrategyPassiveManagerVelodrome contract is crucial for ensuring proper functionality. This parameter can only be adjusted using a specific setter function. If the owner fails to configure this parameter correctly or timely, it may result in unforeseen complications in the contract's operations.

Impact

If the maxTickDeviation parameter is not set by the owner, it could cause the contract to behave unpredictably, potentially leading to operational failures or suboptimal performance. This oversight can have significant implications depending on the contract's usage and the context in which it operates.

https://github.com/sherlock-audit/2024-05-beefy-cowcentrated-liquidity-manager/blob/main/cowcentrated-contracts/contracts/strategies/velodrome/StrategyPassiveManagerVelodrome.sol#L87

Code Snippet

None

Tool used

Manual Review

Recommendation

Set maxTickDeviation parameter on initializing removing the possibility of the owner forgetting to set it.