Closed sherlock-admin4 closed 4 months ago
2 comment(s) were left on this issue during the judging contest.
z3s commented:
Invalid;
panic()
doesn't renounce the owner.
DHTNS commented:
Low -> depends on admin error
Escalate
Although both functions are restricted, different parties can call them (keeper != owner
). Something as simple as bad timing of transactions (e.g. keeper pausing pool at the same time owner is renouncing) can lead to permanent lock of the strategy. Although the likelihood is relatively low, I believe the high impact justifies for Medium severity.
Escalate
Although both functions are restricted, different parties can call them (
keeper != owner
). Something as simple as bad timing of transactions (e.g. keeper pausing pool at the same time owner is renouncing) can lead to permanent lock of the strategy. Although the likelihood is relatively low, I believe the high impact justifies for Medium severity.
You've created a valid escalation!
To remove the escalation from consideration: Delete your comment.
You may delete or edit your escalation comment anytime before the 48-hour escalation window closes. After that, the escalation becomes final.
Escalate
Although both functions are restricted, different parties can call them (
keeper != owner
). Something as simple as bad timing of transactions (e.g. keeper pausing pool at the same time owner is renouncing) can lead to permanent lock of the strategy. Although the likelihood is relatively low, I believe the high impact justifies for Medium severity.
Can I ask why this would be a high impact? During panic all the funds are recovered to the strategy and users can just withdraw? There is no loss of funds if the owner is renounced (which admin is trusted to not do)?
In addition to sponsor comments above, this "issue" relies on admin errors (e.g. communication lapses) between the trusted owner and keeper. Planning to reject escalation and leave issue as it is
Result: Invalid Unique
bughuntoor
medium
If keeper pauses the strategy and
owner
is renounced, it will result in permanent lock of the strategySummary
If keeper pauses the strategy and
owner
is renounced, it will result in permanent lock of the strategyVulnerability Detail
The strategy can be paused via the
panic
function, which has aonlyManager
modifier. The modifier allows only owner or keeper to call the function.However, the problem is that the function responsible for unpausing requires owner to not be renounced. Hence, if
keeper
has to temporarily pause the strategy due to an emergency, they will not be able to laterunpause
it and would result in a permanent lockImpact
Permanent DoS
Code Snippet
https://github.com/sherlock-audit/2024-05-beefy-cowcentrated-liquidity-manager/blob/main/cowcentrated-contracts/contracts/strategies/velodrome/StrategyPassiveManagerVelodrome.sol#L819
Tool used
Manual Review
Recommendation
Remove the unnecessary check for renounced owner