search

sherlock-audit / 2024-05-pooltogether-judging

8 stars 4 forks source link

aman - PUSH0 is not supported by Linea #106

Closed sherlock-admin4 closed 2 months ago

sherlock-admin4 commented 3 months ago

aman

high

PUSH0 is not supported by Linea

Summary

Linea does not support the PUSH0 op code and the contract have ^0.8.24 version of solidity. The contract will not be deployed on Linea Protocol.

Vulnerability Detail

The ReadMe states that :

We're interested to know if there will be any issues deploying the code as-is to any of these chains, and whether their opcodes fully support our application.

The Protocol is going to deploy the contract at Linea platform. Linea does not support the PUSH0 op-code. it can be checked from link.

Impact

The contract will not be deployed on Linea as-is.

Code Snippet

https://github.com/sherlock-audit/2024-05-pooltogether/blob/main/pt-v5-prize-pool/src/PrizePool.sol#L2C1-L3C1

Tool used

Manual Review

Recommendation

Please make sure to follow the steps recommended by Linea team to deploy contract on Linea protocol.

The PUSH0 opcode compatibility was introduced in Solidity compiler version 0.8.20, which came after the London release. However, Linea currently supports Solidity compiler version 0.8.19 and lower, which aligns with the London release of the Ethereum mainnet. To resolve this issue, recompile your contract using Solidity version 0.8.19 or lower.

Duplicate of #79

sherlock-admin4 commented 2 months ago

1 comment(s) were left on this issue during the judging contest.

infect3d commented:

contract will simply not deploy so no risk/loss__ see bullet 24 of invalid findings in sherlock rules