search

sherlock-audit / 2024-05-pooltogether-judging

10 stars 6 forks source link

hash - `permit` is not compatible with DAI #138

Closed sherlock-admin3 closed 3 months ago

sherlock-admin3 commented 4 months ago

hash

medium

permit is not compatible with DAI

Summary

permit is not compatible with DAI

Vulnerability Detail

The EIP-2612 Permit standard is not compatible with dai and other similar tokens which has a different function signature. Hence the depositWithPermit function will revert incase of such tokens

Impact

User's won't be able to use the permit functionality for depositing dai and similar tokens

Code Snippet

https://github.com/sherlock-audit/2024-05-pooltogether/blob/1aa1b8c028b659585e4c7a6b9b652fb075f86db3/pt-v5-vault/src/PrizeVault.sol#L546

Tool used

Manual Review

Recommendation

Acknowledge

nevillehuang commented 3 months ago

Invalid/low severity, users can always use deposit instead.

Also acknowledged as wont fixed in previous audits here