A change in the voteFactor during execution can lead to an inconsistent state in the system.
Vulnerability Detail
If the voteFactor changes during execution, it can lead to an inconsistent state. For example, if voteFactor / fractionDenominator changes from 2 to 1, users who claimed their tokens before the change will have less voting power compared to those who claim after the change. This discrepancy gives later claimants more voting power than expected.
The inconsistent state caused by the change in voteFactor results in some users having more or less voting power than intended. This is considered a medium to high severity issue.
Code Snippet
None
Tool used
Manual Review
Recommendation
Ensure that the voteFactor remains constant during the execution to prevent discrepancies in voting power.
Low 01 Stale Storage
Low/Info issue submitted by 1337web3
Summary
A change in the
voteFactorduring execution can lead to an inconsistent state in the system.Vulnerability Detail
If the
voteFactorchanges during execution, it can lead to an inconsistent state. For example, ifvoteFactor / fractionDenominatorchanges from 2 to 1, users who claimed their tokens before the change will have less voting power compared to those who claim after the change. This discrepancy gives later claimants more voting power than expected.https://github.com/sherlock-audit/2024-05-tokensoft-distributor-contracts-update/blob/main/contracts/packages/hardhat/contracts/claim/factory/AdvancedDistributorInitializable.sol#L188-L198
Impact
The inconsistent state caused by the change in
voteFactorresults in some users having more or less voting power than intended. This is considered a medium to high severity issue.Code Snippet
None
Tool used
Manual Review
Recommendation
Ensure that the
voteFactorremains constant during the execution to prevent discrepancies in voting power.