search

sherlock-audit / 2024-06-leveraged-vaults-judging

9 stars 8 forks source link

lemonmon - Missing implementation of `ClonedCoolDownHolder:rescueTokens` inside the `PendlePTKelpVault` and `PendlePTStakedUSDeVault` vaults #100

Closed sherlock-admin4 closed 2 months ago

sherlock-admin4 commented 2 months ago

lemonmon

Medium

Missing implementation of ClonedCoolDownHolder:rescueTokens inside the PendlePTKelpVault and PendlePTStakedUSDeVault vaults

Summary

The function ClonedCoolDownHolder:rescueTokens is not implemented and can't be called by the vaults PendlePTKelpVault and PendlePTStakedUSDeVault.

Vulnerability Detail

The function ClonedCoolDownHolder:rescueTokens has the onlyVault modifier, so it can only be called by the vault. However the PendlePTKelpVault and PendlePTStakedUSDeVault have no implementation and no way to call the ClonedCoolDownHolder:rescueTokens functions.

Impact

The recovery of lost tokens in the vaults PendlePTKelpVault and PendlePTStakedUSDeVault can't be done, since the vaults have no way to call the function ClonedCoolDownHolder:rescueTokens, which can only be called by the vault. Thus, lost tokens may be stuck in the vault forever.

Code Snippet

https://github.com/sherlock-audit/2024-06-leveraged-vaults/blob/14d3eaf0445c251c52c86ce88a84a3f5b9dfad94/leveraged-vaults-private/contracts/vaults/staking/protocols/ClonedCoolDownHolder.sol#L23-L25

Tool used

Manual Review

Recommendation

Consider implementing some functionality into the vaults PendlePTKelpVault and PendlePTStakedUSDeVault to call ClonedCoolDownHolder:rescueTokens, so that lost tokens can be recovered by these vaults.

sherlock-admin4 commented 2 months ago

1 comment(s) were left on this issue during the judging contest.

0xmystery commented:

Lacks proof to substantiate the bug