sherlock-audit / 2024-06-magicsea-judging

8 stars 5 forks source link

neogranicen - User will be inable to claim rewards for amounts he deposited after a big emrgency withralw #688

Closed sherlock-admin4 closed 4 months ago

sherlock-admin4 commented 4 months ago

neogranicen

Medium

User will be inable to claim rewards for amounts he deposited after a big emrgency withralw

Summary

emergencyWithdraw does not update uses debt after leads to inability to claim rewards for amounts he deposited after a big emrgency withdraw

Vulnerability Detail

Alice deposits 100 ether
Alice emergency withdrawals the 100 ehter
alice debt that was set for the 100 ether is not chaned
alice deposits again but a small amount
alice waits and try to claim rewards
alice can no longer claim rewards or withdraw or deposit because of underflow cause by the the debt amount that was not removes
Impact

alice wont be able to deposit or withdraw or claim rewards any longer

Code Snippet

https://github.com/sherlock-audit/2024-06-magicsea/blob/main/magicsea-staking/src/MasterchefV2.sol#L326

Tool used

Manual Review

Recommendation

0xSmartContract commented 4 months ago

Insufficient code detail and insufficient content , so invalid