search

sherlock-audit / 2024-06-symmetrical-update-2-judging

0 stars 0 forks source link

Unnecessary Nonce Increase in LockQuote #25

Closed Navid-Fkh closed 1 week ago

Navid-Fkh commented 1 week ago

Summary

The nonce increase in the LockQuote process is unnecessary because there are no actual changes occurring during this process. UPNL remain unchanged, so it is acceptable not to increase the nonce.

Vulnerability Detail

Although increasing the nonce does not cause any economic damage, it can create complications in certain edge cases, such as during the liquidation process. In these scenarios, it is preferable not to increase the nonce of the involved parties unnecessarily.

Impact

The unnecessary nonce increase may complicate the liquidation process for the liquidator. Specifically, it could make it more difficult to liquidate party B, as party B is constantly locking quotes.

WangSecurity commented 1 week ago

Please don’t create issues during the escalation period, they won’t be reviewed and rewarded.

sherlock-admin2 commented 1 week ago

The protocol team fixed this issue in the following PRs/commits: https://github.com/SYMM-IO/protocol-core/pull/56

sherlock-admin2 commented 3 days ago

The Lead Senior Watson signed off on the fix.