Closed sherlock-admin4 closed 4 months ago
Lone Oily Rooster
Low/Info
isApprovedOrOwner
krkbaa
in IVotingEscrow.sol contract the isApprovedOrOwner function should have a view or pure modifier because it is a getter function that does not change the state. https://github.com/sherlock-audit/2024-06-velocimeter/blob/main/v4-contracts/contracts/interfaces/IVotingEscrow.sol#L23 also the team function https://github.com/sherlock-audit/2024-06-velocimeter/blob/main/v4-contracts/contracts/interfaces/IVotingEscrow.sol#L16
team
the function may be misinterpreted.
Manual Review
Add the View Modifier
Lone Oily Rooster
Low/Info
Missing View Modifier in
isApprovedOrOwnerFunctionkrkbaa
Summary
Vulnerability Detail
in IVotingEscrow.sol contract the
isApprovedOrOwnerfunction should have a view or pure modifier because it is a getter function that does not change the state. https://github.com/sherlock-audit/2024-06-velocimeter/blob/main/v4-contracts/contracts/interfaces/IVotingEscrow.sol#L23 also theteamfunction https://github.com/sherlock-audit/2024-06-velocimeter/blob/main/v4-contracts/contracts/interfaces/IVotingEscrow.sol#L16Impact
the function may be misinterpreted.
Code Snippet
Tool used
Manual Review
Recommendation
Add the View Modifier