proxyGauge that inherits IGauge interface does not implement getReward()` function.
Vulnerability Detail
The implementation contract does not implement any functionality for getReward().
Impact
The call to getReward(...) on this interface will not render any functionality. Since the function signature does not return any return value, there is no indication to the caller of any failure.
If the contract does not intent to implement getReward(...), then it should revert and hence notifying the caller of the failure, if called.
The current implementation suppresses and hence might leave an impresses that everything worked as expected, while it did not.
Careful Wooden Caribou
Low/Info
proxyGauge::getReward(...) is not implemented
Summary
proxyGaugethat inheritsIGaugeinterface does not implement getReward()` function.Vulnerability Detail
The implementation contract does not implement any functionality for
getReward().Impact
The call to
getReward(...)on this interface will not render any functionality. Since the function signature does not return any return value, there is no indication to the caller of any failure.Code Snippet
https://github.com/sherlock-audit/2024-06-velocimeter/blob/main/v4-contracts/contracts/ProxyGauge.sol#L48-L50
Tool used
Manual Review
Recommendation
If the contract does not intent to implement
getReward(...), then it should revert and hence notifying the caller of the failure, if called. The current implementation suppresses and hence might leave an impresses that everything worked as expected, while it did not.