sherlock-audit / 2024-08-flayer-judging

0 stars 0 forks source link

Lone Powder Shrimp - a user can use the relist function to buy because it is more cheaper than the fillListings #744

Open sherlock-admin4 opened 4 days ago

sherlock-admin4 commented 4 days ago

Lone Powder Shrimp

High

a user can use the relist function to buy because it is more cheaper than the fillListings

Summary

in fillListings the caller have to first transfer the totalPrice and also burn the base amount that the lister received when listing but in relist the user only have to Pay listingPrice - listingFloorPrice and the tax so the base amount that the lister received when depositing is not accounted in here

Root Cause

https://github.com/sherlock-audit/2024-08-flayer/blob/main/flayer/src/contracts/Listings.sol#L625 in Listing function relist is more cheaper when buying

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

loss for the protocol

PoC

No response

Mitigation

No response