Happy Green Chimpanzee - cache the length of loop to save gas

[sherlock-admin4]

Happy Green Chimpanzee

Low/Info

cache the length of loop to save gas

Summary

it is better to cache the length of list rather then loading it from the variable

Vulnerability Detail

in a lot of area where for loop is used , it is going to use like this array.length , it costs a alot more gas than expected

Impact

cause a lot more gas

Code Snippet

• Found in src/contracts/Listings.sol Line: 137

        for (uint i; i < _createListings.length; ++i) {

• Found in src/contracts/Listings.sol Line: 306

          for (uint i; i < _modifyListings.length; ++i) {

  Tool used

Manual Review

Recommendation

uint len = _createListings.length;

- for (uint i; i < _createListings.length; ++i)
+ for (uint i; i < len; ++i)