Closed sherlock-admin4 closed 3 months ago
Fancy Raisin Gorilla
Low/Info
shouldDrawRaffle
WinnablesTicketManager.sol
In WinnablesTicketManager.sol the function should return true or false based on a condition but the function always returns true.
Here the internal function _checkShouldDraw does not return anything it only reverts. Which contradicts the @return statement. https://github.com/sherlock-audit/2024-08-winnables-raffles/blob/main/public-contracts/contracts/WinnablesTicketManager.sol#L149-L155
_checkShouldDraw
@return
No response
The protocol returns incorrect information, resulting in misleading users.
Change _checkShouldDraw to return a bool and based on that bool return the correct answer.
Fancy Raisin Gorilla
Low/Info
shouldDrawRaffleinWinnablesTicketManager.solalways returns trueSummary
In
WinnablesTicketManager.solthe function should return true or false based on a condition but the function always returns true.Root Cause
Here the internal function
_checkShouldDrawdoes not return anything it only reverts. Which contradicts the@returnstatement. https://github.com/sherlock-audit/2024-08-winnables-raffles/blob/main/public-contracts/contracts/WinnablesTicketManager.sol#L149-L155Internal pre-conditions
No response
External pre-conditions
No response
Attack Path
No response
Impact
The protocol returns incorrect information, resulting in misleading users.
PoC
No response
Mitigation
Change
_checkShouldDrawto return a bool and based on that bool return the correct answer.