Closed sherlock-admin4 closed 3 months ago
Fancy Raisin Gorilla
Low/Info
shouldCancelRaffle
WinnablesTicketManager.sol
shouldCancelRaffle always returns true rather than returning the correct answer based on the condition.
We can see that @return states that it should either return true or false but it is hardcoded to always return true. https://github.com/sherlock-audit/2024-08-winnables-raffles/blob/main/public-contracts/contracts/WinnablesTicketManager.sol#L157-L163
@return
No response
Incorrect return of information may lead to incorrect logic implementation and incorrect information fetched by the users.
Make _checkShouldCancel return a bool value and return this value.
_checkShouldCancel
Fancy Raisin Gorilla
Low/Info
The function
shouldCancelRafflein the contractWinnablesTicketManager.solalways returns trueSummary
shouldCancelRafflealways returns true rather than returning the correct answer based on the condition.Root Cause
We can see that
@returnstates that it should either return true or false but it is hardcoded to always return true. https://github.com/sherlock-audit/2024-08-winnables-raffles/blob/main/public-contracts/contracts/WinnablesTicketManager.sol#L157-L163Internal pre-conditions
No response
External pre-conditions
No response
Attack Path
No response
Impact
Incorrect return of information may lead to incorrect logic implementation and incorrect information fetched by the users.
PoC
No response
Mitigation
Make
_checkShouldCancelreturn a bool value and return this value.