sherlock-audit / 2024-09-predict-fun-judging

0 stars 0 forks source link

Merry Glass Kitten - Unused event `LoanTokenStatusUpdated` #333

Closed sherlock-admin2 closed 2 days ago

sherlock-admin2 commented 2 days ago

Merry Glass Kitten

Low/Info

Unused event `LoanTokenStatusUpdated`

Summary

The IPredictDotLoan::LoanTokenStatusUpdated event is declared but it is not emitted by any function.

Root Cause

In IPredictDotLoan.sol:123 declared an event called LoanTokenStatusUpdated but it is not emitted by any function in any contracts.

https://github.com/sherlock-audit/2024-09-predict-fun/blob/main/predict-dot-loan/contracts/interfaces/IPredictDotLoan.sol#L123

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

No response

PoC

No response

Mitigation

Check whether these events should be used and if not remove them

sherlock-admin2 commented 14 hours ago

The protocol team fixed this issue in the following PRs/commits: https://github.com/PredictDotFun/predict-dot-loan/pull/31