sherlock-audit / 2024-09-symmio-v0-8-4-update-contest-judging

0 stars 0 forks source link

Petite Spruce Mammoth - Using `SafeMath` increases gas costs unnecessarily without adding any extra safety in `LibLockedValues.sol` #75

Closed sherlock-admin4 closed 1 week ago

sherlock-admin4 commented 1 week ago

Petite Spruce Mammoth

Low/Info

Using SafeMath increases gas costs unnecessarily without adding any extra safety in LibLockedValues.sol

Summary

Using SafeMath in LibLockedValues.sol increases gas costs unnecessarily without adding any extra safety.

Root Cause

The code uses SafeMath for all arithmetic operations (addition, subtraction, multiplication, and division). https://github.com/sherlock-audit/2024-09-symmio-v0-8-4-update-contest/blob/main/protocol-core/contracts/libraries/LibLockedValues.sol#L18 In Solidity versions >=0.8.0, overflow and underflow checks are built-in, so SafeMath is redundant and unnecessary. Using it increases gas costs unnecessarily without adding any extra safety.

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

Using SafeMath increases gas costs unnecessarily without adding any extra safety.

PoC

No response

Mitigation

If using Solidity >=0.8.0, you can remove SafeMath and rely on the built-in overflow and underflow checks.