Closed sherlock-admin4 closed 1 week ago
Petite Spruce Mammoth
Low/Info
SafeMath
LibLockedValues.sol
Using SafeMath in LibLockedValues.sol increases gas costs unnecessarily without adding any extra safety.
The code uses SafeMath for all arithmetic operations (addition, subtraction, multiplication, and division). https://github.com/sherlock-audit/2024-09-symmio-v0-8-4-update-contest/blob/main/protocol-core/contracts/libraries/LibLockedValues.sol#L18 In Solidity versions >=0.8.0, overflow and underflow checks are built-in, so SafeMath is redundant and unnecessary. Using it increases gas costs unnecessarily without adding any extra safety.
No response
Using SafeMath increases gas costs unnecessarily without adding any extra safety.
If using Solidity >=0.8.0, you can remove SafeMath and rely on the built-in overflow and underflow checks.
Petite Spruce Mammoth
Low/Info
Using
SafeMath
increases gas costs unnecessarily without adding any extra safety inLibLockedValues.sol
Summary
Using
SafeMath
inLibLockedValues.sol
increases gas costs unnecessarily without adding any extra safety.Root Cause
The code uses
SafeMath
for all arithmetic operations (addition, subtraction, multiplication, and division). https://github.com/sherlock-audit/2024-09-symmio-v0-8-4-update-contest/blob/main/protocol-core/contracts/libraries/LibLockedValues.sol#L18 In Solidity versions >=0.8.0, overflow and underflow checks are built-in, soSafeMath
is redundant and unnecessary. Using it increases gas costs unnecessarily without adding any extra safety.Internal pre-conditions
No response
External pre-conditions
No response
Attack Path
No response
Impact
Using
SafeMath
increases gas costs unnecessarily without adding any extra safety.PoC
No response
Mitigation
If using Solidity >=0.8.0, you can remove
SafeMath
and rely on the built-in overflow and underflow checks.