sherlock-audit / 2024-10-ethos-network-judging

0 stars 0 forks source link

Falendar - Missing `whenNotPaused` modifier in `uninviteUser` #239

Open sherlock-admin3 opened 2 weeks ago

sherlock-admin3 commented 2 weeks ago

Falendar

Medium

Missing whenNotPaused modifier in uninviteUser

Summary

The uninviteUser function is missing the whenNotPaused modifier, allowing the function to be called even when the contract is paused.

Root Cause

In EthosProfile.sol the uninviteUser function lacks the whenNotPaused modifier.

Internal pre-conditions

The contract must be in a paused state.

External pre-conditions

None

Attack Path

An attacker or user calls the uninviteUser function while the contract is paused. Despite the paused state, the function executes, potentially leading to unintended changes.

Impact

Allows storage modifications during a paused state.

PoC

None needed

Mitigation

Add whenNotPaused modifier to the uninviteUser function.