sherlock-audit / 2024-10-ethos-network-judging

0 stars 0 forks source link

justAWanderKid - Malicious User Can Block Other Members of the Same Profile from Interacting with the Ethos Network by Continuously Archiving the Profile Whenever is Restored #250

Open sherlock-admin2 opened 3 weeks ago

sherlock-admin2 commented 3 weeks ago

justAWanderKid

Medium

Malicious User Can Block Other Members of the Same Profile from Interacting with the Ethos Network by Continuously Archiving the Profile Whenever is Restored

Description

In the current implementation of EthosProfile::archiveProfile() and EthosProfile::restoreProfile(), any user can archive and unarchive the profile.

If a user decides to act maliciously, they can archive the profile and whenever it is restored by other users, malicious user will archive the profile immediately again by back-running. effectively blocking other users from interacting with the Ethos Network.

This behavior prevents users from being able to add new replies, submitting reviews, creating or restoring attestations, and upvoting or downvoting activity items.

Impact

A malicious user can effectively disable a profile by continuously archiving it, preventing other members from engaging in essential activities on the Ethos Network.

This would block users from submitting reviews, comments, upvotes, downvotes, and creating or restoring attestations.

Such vulnerablity impact the user experience in negative way, as members are unable to contribute to or maintain active profile.

Recommended Mitigation

each profile should have primary user that has administrative powers, including:

  1. only profile admin can archive/restore any activity item.
  2. only profile admin can register/un-register any user.
  3. profile admin can whitelist trusted user, so they are able to call onlyProfileAdmin functions.