Open sherlock-admin3 opened 3 weeks ago
pashap9990
Medium
Admins cannot pause or unpause contracts
based on readme we can realize owner just is responsible for withdrawfunds and grantRules and revokeRules and upgradeContracts its mean Admins should access to another mangment functions but admins don't have access to this functions
InteractionControl:pauseAll InteractionControl:unpauseAll InteractionControl:pauseContract InteractionControl:unpauseContract InteractionControl:removeControlledContractName InteractionControl:addControlledContractNames ContractAddressManager::updateContractAddressesForNames
https://github.com/sherlock-audit/2024-10-ethos-network/blob/main/ethos/packages/contracts/contracts/utils/InteractionControl.sol#L13
https://github.com/sherlock-audit/2024-10-ethos-network/blob/main/ethos/packages/contracts/contracts/utils/ContractAddressManager.sol#L21
Admin don't have access to some functions which is important for management contracts
consider to change modifers for this functions
pashap9990
Medium
Admins cannot pause or unpause contracts
Summary
Admins cannot pause or unpause contracts
Root Cause
based on readme we can realize owner just is responsible for withdrawfunds and grantRules and revokeRules and upgradeContracts its mean Admins should access to another mangment functions but admins don't have access to this functions
Code Snippet
https://github.com/sherlock-audit/2024-10-ethos-network/blob/main/ethos/packages/contracts/contracts/utils/InteractionControl.sol#L13
https://github.com/sherlock-audit/2024-10-ethos-network/blob/main/ethos/packages/contracts/contracts/utils/ContractAddressManager.sol#L21
Impact
Admin don't have access to some functions which is important for management contracts
Mitigation
consider to change modifers for this functions