sherlock-audit 2024-11-telcoin-judging issues

sherlock-audit / 2024-11-telcoin-judging

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Loud Wooden Mantis - Unnecessary import of `AccessControlUpgradeable` in `swap::AmirX.sol` as it is already inherited in `StablecoinHandler.sol`

#239 sherlock-admin4 closed 1 week ago
0
Young Lime Mouse - Non-Standard `decimals` Storage May Cause Compatibility Issues

#238 sherlock-admin4 closed 1 week ago
0
Plain Cream Kookaburra - Over-restricted Access Control on unpause Function Leads to Centralization Risk

#237 sherlock-admin4 closed 1 week ago
0
Raspy Syrup Otter - require() statement in UpdateXYZ() in StablecoinHandler.sol will increase gas spent for MAINTAINER_ROLE

#236 sherlock-admin4 closed 1 week ago
0
Early Viridian Haddock - _onceBlacklisted() transfer tokens even when amount is 0

#235 sherlock-admin4 closed 1 week ago
0
MaslarovK - Insufficient Supply Limit Checks in `_stablecoinSwap()` Function, Leading to Potential DoS in `StablecoinHandler.sol`

#234 sherlock-admin2 opened 1 week ago
0
CipherHawk - Pauser cannot halt contract operations during emergencies

#233 sherlock-admin4 opened 1 week ago
0
s0x0mtee - Blacklisted addresses can still call/interact with Telcoin core/swap functions

#232 sherlock-admin2 opened 1 week ago
0
0x73696d616f - Malicious wallet may easily grief `SWAPPER_ROLE` by a significant margin leading to severe loss of funds

#231 sherlock-admin4 opened 1 week ago
0
rscodes - Inconsistent behaviour between `swap` and `defiToStablecoinSwap`, causing `ss.oAmount` to be wrong

#230 sherlock-admin2 opened 1 week ago
0
Aamirusmani1552 - The protocol does not account for dual fee on fee on transfer token both stable fee currency and stable origin tokens are equal.

#229 sherlock-admin4 opened 1 week ago
0
CipherHawk - Support role may fail to rescue tokens due to unchecked return values

#228 sherlock-admin2 opened 1 week ago
0
MaslarovK - Lack of Slippage Protection and Deadline Parameter in `AmirX.sol` Contract Swaps

#227 sherlock-admin4 opened 1 week ago
0
shaflow01 - The contract should immediately revoke the authorization, rather than waiting for the next interaction.

#226 sherlock-admin2 opened 1 week ago
0
0xlucky - If Fee token would be Buy Token, then StableCoinSwap will revert

#225 sherlock-admin4 opened 1 week ago
0
CipherHawk - Support role may fail to rescue certain ERC20 tokens

#224 sherlock-admin2 opened 1 week ago
0
shaflow01 - The `swap` function may not perform `defiSwap` when `directional` is true.

#223 sherlock-admin4 opened 1 week ago
0
frndz0ne - Insufficient checks in `AmirX::swap` will allow change of protocol's state without verification

#222 sherlock-admin2 opened 1 week ago
0
Cayde-6 - wrong value being passed in `_buyBack` lead to loss of funds for swapper

#221 sherlock-admin4 opened 1 week ago
1
Saurabh_Singh - UnderFlow revert in the `amirX::swap` function because of (fBalance - iBalance) substraction.

#220 sherlock-admin2 opened 1 week ago
0
POB - POB - Underflow in `AmirX::swap` and `AmirX::defiToStablecoinSwap` functions

#219 sherlock-admin4 opened 1 week ago
0
TessKimy - Missing gap on upgradable contract

#218 sherlock-admin2 opened 1 week ago
0
parzival - `Stablecoin.sol` and `AmirX.sol` are upgradable contracts but inherit from contracts that does not have storage gap

#217 sherlock-admin4 opened 1 week ago
0
0x60scs - {0x60scs} will {medium} {The money in the account to be blacklisted can be transferred to another account in advance.}

#216 sherlock-admin4 closed 1 week ago
0
AdamSzymanski - Underfunding of Buyback and Fee Distributions Due to Fee-on-Transfer Tokens

#215 sherlock-admin2 opened 1 week ago
0
nikhilx0111 - incorrect assumption can be problematic

#214 sherlock-admin4 opened 1 week ago
0
Astrotimi - Incorrect Assumption of Stablecoin Market Stability

#213 sherlock-admin2 opened 1 week ago
0
nikhil840096 - More than, deposited stable tokens will be minted during the directional swap, for fee on transfer tokens.

#212 sherlock-admin2 opened 1 week ago
0
POB - POB - Lost funds in the `AmirX::_buyBack` function when `DefiSwap.defiSafe` is set to `address(0)`

#211 sherlock-admin2 opened 1 week ago
0
AdamSzymanski - Inconsistent Swap Execution Due to Ambiguous `directional` Logic

#210 sherlock-admin2 opened 1 week ago
0
hard1k - In `AmirX.sol` the `swap` function will lead to exexpected behaviour when directional = false due to wrong implementation

#209 sherlock-admin2 opened 1 week ago
0
MaslarovK - Unnecessary Restrictions within `swap` Function when `ss.origin == ss.target`

#208 sherlock-admin2 opened 1 week ago
0
0xlucky - DefiToStableCoinSwap can revert due to miscalculation of tokens

#207 sherlock-admin2 opened 1 week ago
0
PeterSR - Same token for fees and origin for stable coin swap

#206 sherlock-admin2 opened 1 week ago
0
0xjarix - Malicious user can DoS future stablecoin swaps for user by allowing the total supply to drop below the minimum limit after burning the specified amount

#205 sherlock-admin2 opened 1 week ago
0
Saurabh_Singh - The payment of fees in `stablecoinhandler::_stablecoinSwap` can be bypassed if one of the parameters, `stablecoinFeeCurrency` or `stablecoinFeeSafe`, is set to zero.

#204 sherlock-admin3 opened 1 week ago
0
Artur - Fee on Transfer Tokens Will Cause Protocol to Lose Funds

#203 sherlock-admin3 opened 1 week ago
0
0x73696d616f - `StablecoinHandler::stablecoinSwap()` does not enforce price or deadline limits in `ss.oAmount` and `ss.tAmount` leading to losses in case of depeg

#202 sherlock-admin3 opened 1 week ago
0
0xsalami - Storage collision risk in upgradeable contracts

#201 sherlock-admin3 opened 1 week ago
0
0xKann - Audit Report: Missing Checks for Fee Currency and Fee Safe Address

#200 sherlock-admin3 opened 1 week ago
0
gd - Unverified Parameters in swap Function May Lead to Unintended Behavior

#199 sherlock-admin3 opened 1 week ago
0
Abhan1041 - Total supply of stable coin can be less than minimum supply in such cases

#198 sherlock-admin3 opened 1 week ago
0
elvin.a.block - `AmirX._feeDispersal` will incorrectly send entire TELCOIN balance instead of buyback remainder after referral fee dispersal

#197 sherlock-admin3 opened 1 week ago
0
Astrotimi - If any stablecoin depegs, oracle will fail, disabling swaps

#196 sherlock-admin3 opened 1 week ago
0
0xsalami - Fee handling vulnerability allows fee bypass in swap operations

#195 sherlock-admin3 opened 1 week ago
0
MaslarovK - The `BURNER` cannot burn tokens from blacklisted accounts due to the check in `_update`

#194 sherlock-admin2 opened 1 week ago
0
smbv-1923 - `defiToStablecoinSwap()` would fail if `ss.stablecoinFeeCurrency` and `ss.origin` token are same

#193 sherlock-admin3 opened 1 week ago
0
Aamirusmani1552 - Users will lose tokens when there is a swap fee.

#192 sherlock-admin2 opened 1 week ago
0
smbv-1923 - `StablecoinHandler::_stablecoinSwap()` would fail under certain conditions

#191 sherlock-admin3 opened 1 week ago
0
x0rc1ph3r - `stablecoin::StablecoinHandler.sol` has `renounceRole` function from OpenZepellin's `AccessControlUpgradeable.sol` that can be called, making all the primary functions uncallable

#190 sherlock-admin2 opened 1 week ago
0