search

sherlock-project / sherlock

Hunt down social media accounts by username across social networks
https://sherlockproject.xyz
MIT License
60.53k stars 6.96k forks source link

Deprecate Python 3.8 #2267

Closed ppfeister closed 2 weeks ago

ppfeister commented 2 months ago

Python 3.8 is nearing EOL, and it's being deprecated here to allow for more ready dependency resolution between pandas and numpy, avoiding a fatal import.

fc39 will be EOL November 12, 2024, and most users should have upgraded to fc40 by now, so I don't see much reason to continue support for that either.

Closes #2266

ppfeister commented 2 weeks ago

Now that fc39 and 3.8 are finally EOL, I don't see any reason to keep withholding a merge. Any opposition to said merge? @sdushantha

Simple deprecation of 3.8. Should have no functional difference, although the pandas issue may also become less prevalent (as a positive side effect).

sdushantha commented 2 weeks ago

LGTM