search

sherlock-project / sherlock

Hunt down social media accounts by username across social networks
https://sherlockproject.xyz
MIT License
60.52k stars 6.96k forks source link

False positive for: A List of Websites #2273

Open MrGranddy opened 2 months ago

MrGranddy commented 2 months ago

Additional info

https://cavalier.hudsonrock.com/ https://hackenproof.com/ https://forum.hackthebox.com/ https://www.librarything.com/ https://lichess.org/ https://www.tldrlegal.com/

I was going to create a PR for the fix, yet I am extremely disappointed to see that the codebase is not Pythonic at all. It gave me headaches. I hope you'll fix these FPs and find salvation in PEP8.

Additional Information:

Code of Conduct

rsb-23 commented 2 months ago

tldrlegal have same response for all users, hence can't be fixed. I have fixed the rest.

rsb-23 commented 2 months ago

I too would suggest to add more linters to code, maybe using pre-commit and pyproject.toml for config. This will make code more consistent and maintainable.