search

sherlock-project / sherlock

Hunt down social media accounts by username across social networks
https://sherlockproject.xyz
MIT License
60.53k stars 6.96k forks source link

Fix Invalid usernames for number of pages #2340

Closed mikebgrep closed 2 weeks ago

mikebgrep commented 1 month ago

With this PR, I add regexCheck value in data.json file that will check for valid username in the web pages related to this issue https://github.com/sherlock-project/sherlock/issues/2313. Its minimize the chance to return a result for a invalid username as the rules for username from the pages is considered also

ppfeister commented 2 weeks ago

Changes reverted.

Upon further review, some patterns seem to be incorrect, even if the absurdly long usernames are dealt with. For instance, Discord allows periods, HackTheBox allows up to 32 chars, etc. Corrections are welcome if desired.

Should also note that when within length, F+s are still present.

mikebgrep commented 2 weeks ago

It's good to know that these patterns didn't work.Well done for reverting it. Regards