search

sherman5 / MeleeModdingLibrary

A C library for modding Super Smash Bros Melee
https://sherman5.github.io/MeleeModdingLibrary/
GNU General Public License v3.0
61 stars 3 forks source link

Broken links on the wiki sidebar #20

Open jodizzle opened 7 years ago

jodizzle commented 7 years ago

When I check out the landing page of the wiki, I see that many of the links on the sidebar are misformated. There's also some misformatting in the documentation itself, like on this page.

I would submit a pull request, but apparently GitHub doesn't make submitting PRs for wikis very convenient.

sherman5 commented 7 years ago

huh, that broke without me changing anything. It seems like it works sometimes and doesn't work other times. My guess is the spaces in link names throws things off. I'll fix that soon.

sherman5 commented 7 years ago

Sidebar is fixed, but gonna take a bit to find all the broken links throughout the wiki.

Let me know if you come across any more broken links... I'll keep the issue open for now.

jodizzle commented 7 years ago

So I've browsed through the wiki, and it seems like the only busted links left are on this page: https://github.com/sherman5/MeleeModdingLibrary/wiki/Tutorial. I'll let you know if I find any more.

And yeah, it looks like spaces in the link names are messing with how Github renders markdown. Using underscores is usually better (makes copy/pasting nicer as well).

As I play with the library more, I think I'll have some suggestions for the tutorial. Would you prefer that be discussed in Github issues or somewhere else?

sherman5 commented 7 years ago

For suggestions, I think the best place would be the discord (I just made a suggestions channel). That way it is a little more visible and we might get more feedback.

Once an idea is pretty well thought out, we can move it to Github Issues to manage the actual implementation.

Does that sound like a good plan?

jodizzle commented 7 years ago

Yep, that sounds reasonable. Thanks.