Closed ff0255 closed 2 months ago
Thanks for looking into this. Yes we have always used the https://github.com/monero-project/monero/blob/master/docs/ANONYMITY_NETWORKS.md manual for our settings in the past and it's understandable the have been updated over the years. I'll also say that the master/docs/ANONYMITY_NETWORKS.md manual was pretty obscure in the past too and it took quite a bit of trial and error testing.
I've got friday evening free to test this. I can't see a reason not to merge this and the tor incoming connections may improve stability overall. I'll use this opportunity to further test/update tor settings and bring things up to date.
You're welcome :^) I thought to separate this 3 commits into 2 pull requests (tor and ipv4), but at the moment can't figure out github workflow and division into right branches. Feel free to correct me.
Ok, still working on this and reminds me of how slow tor is.
So a slight tweak in using port 28083 (instead of previous 18083 - as used before zmq had greater adoption due to P2Pool mining). This could also allow in future for a tor-ified zmq hidden service rule. I don't see a need for it just yet but best keep the port clear.
This is technically good to merge, as per the PR title but I'm tempted to spend a bit longer researching and optimising anything that can increase connection reliability and speed of Wallet RPC connections? (My Monerujo wallet with Orbot is sketchy and intermittent)
@ff0255 Sorry got side-tracked. Will merge this in the next 24 hours unless you have any other input? Then will keep an open issue to try and optimise the RPC connection stability/speed.
Sorry got side-tracked.
@shermand100 Sorry, me too. I don't see anything bad in changing port number to 28083, except maybe one suggestion... that somebody might get confused thinking it's testnet node (default ports: 2808* for testnet https://getmonero.dev/infrastructure/networks.html) Аlthough I'm not sure about the relevance of that documentation. Anyway I think it's OK to use 28083. Unfortunately I can't help with optimisation of RPC connection. Usually I test it in Tor browser (it shows stats page if RPC works). I tried to test RPC with Monerujo, but unfortunately Monerujo is crashing on my device. Maybe later when I resolve issues with Monerujo I'll try to test again.
Yeah understood. Where possible I try not to deviate from anything in the official Monero project documentation as I don't want us to "do our own thing". When issues arise it helps to be "default" as it massively helps troubleshooting. Currently the Anonymity docs use port 28083 in their examples:
https://github.com/monero-project/monero/blob/master/docs/ANONYMITY_NETWORKS.md#inbound-connections
I'd think it best to mirror their example and change if they do. There's often good reason for it.
I too am struggling with RPC optimisations and wonder if it's the Monerujo app. However I recently learnt that the Cake wallet uses the came core wallet RPC code so unless the base code gets a rework I feel there are limited choices for testing alternative wallets.
Hello and thank you for this project! o/ There is a lot of info on the Internet on running monerod+Tor, but some is outdated. It seems that up to date info is here: https://github.com/monero-project/monero/blob/master/docs/ANONYMITY_NETWORKS.md I have tested this fix on my node. Before this fix I had only Tor outbound connections (running over a month):
Now I have both inbound and outbound (running several hours after fix):
P.S. This is my first PR, please correct me if I'm doing something wrong. I changed only line 8 in those files but github auto removed whitespaces in line 31 for some reason... And now it looks like I changed it... But I didn't...
UPD Sorry, I didn't realize that my 3rd commit (inbound p2p ipv4) that I made after publishing this PR will be included here too... I need to learn github more...I guess there's no way to revert it on web-version of github. As far as I can see, the option "--p2p-bind-ip 127.0.0.1" is from outdated manuals with torsocks. Now we don't use it. And I doubt that we need "TORSOCKS_ALLOW_INBOUND=1" This fix is also tested on my node, p2p ipv4 INC is working, but I'm not an IT expert, so maybe there are some privacy/security issues related to it?