DEVICE_IP not easily modifiable

shermand100 / PiNodeXMR

Monero Node for Single Board Computers with Web Interface and additional tools pre-configured. Self Installing.

GNU General Public License v3.0

213 stars 41 forks source link

DEVICE_IP not easily modifiable #42

Closed roryeckel closed 2 years ago

roryeckel commented 3 years ago

Hi, as seen in most of the sh files (monerod-start.sh, -stop.sh), $DEVICE_IP is being assigned. In order to get monerod to bind on another IP, it seems I'd have to edit a dozen files. If that's true, the assignment of DEVICE_IP could be put into a single script and called by the others. I don't want to edit a dozen files every update. Thanks.

shermand100 commented 3 years ago

Hi, just seen your telegram messages that led to this. What you're saying makes sense and I'm currently building a new UI that allows for more customisation whilst reducing the bloat of options displayed to the user. Basically making it cleaner. As part of this then I'll make device IP a set variable in the settings database for easier editing. Temporarily for now it should only needed to edit manually for the mode you want to run (example for private node "monerod-start.sh, line 3), and the for the status script set new IP value in monero-staus.sh, line 25

shermand100 commented 2 years ago

Implemented: New variable file deviceIp.sh which holds the hostname -I call, all start scripts and status script calls this file.

Raspberry Pi OS branch commit: https://github.com/monero-ecosystem/PiNode-XMR/commit/30b1af54547d63be5e44878e57b775659c107cb9

Cherry Picked into Armbian install branch: https://github.com/monero-ecosystem/PiNode-XMR/commit/5e1f2ee2558337ccbe8e5b4abf1e39178aeec22b