search

shermp / Kobo-UNCaGED

UNCaGED, for Kobo devices
GNU Affero General Public License v3.0
95 stars 7 forks source link

[WIP] Code reorganisation & refactoring #20

Closed shermp closed 5 years ago

shermp commented 5 years ago

@geek1011 suggested that maybe bunging everything into the main package wasn't the best of ideas, and I agree,

This PR is primarily around moving stuff out of main into separate packages, with a bit of code refactoring thrown in. There's a lot more that could be done later.

I'm not done yet, but I think there's enough here to start obtaining feedback. Hopefully what I've done will make for easier refactoring and testing down the road.

pgaskin commented 5 years ago

I'll update my other WIP pull requests after this is merged and I have more time.

shermp commented 5 years ago

Alright, I've probably done enough damage for one PR...

There's probably still more that could be done, but then you get to the point of ...but just one more thing

If anyone is willing to review this, please do.

shermp commented 5 years ago

Thanks for the review @geek1011

I think I've resolved most of your comments. There were a few which would require an interface change with UNCaGED, which I feel should be resolved separately.