shermp / Kobo-UNCaGED

UNCaGED, for Kobo devices
GNU Affero General Public License v3.0
98 stars 7 forks source link

Building with Docker (and therefore GitHub actions #33

Open shermp opened 3 years ago

shermp commented 3 years ago

So, I really want to get some github actions going, but I kind of need a docker image to do it with.

The easiest option looks to be golang-crossbuild. My main concern is that this won't have any Kobo specific tweaks to the build system. How critical are the Kobo tweaks @NiLuJe ?

Another option might be to extend the koreader/kokobo image with Go, if I can get it working.

Or I could build my own koxtoolchain + Go docker image.

Another option may be NickelTC, although I would prefer newer compiler versions for building Go programs.

Any thoughts @NiLuJe or @pgaskin ?

NiLuJe commented 3 years ago

I have no idea what golang-crossbuild uses, but it appears to be Debian based, so, even despite that fact, it's going to be hilariously too recent, so, it'll just create plain unusable binaries ;).

You should be able to use koxtoolchain on pretty much anything, though, so, basically anything that works for you as a base can be tweaked to include a usable TC.

shermp commented 3 years ago

I have no idea what golang-crossbuild uses, but it appears to be Debian based, so, even despite that fact, it's going to be hilariously too recent, so, it'll just create plain unusable binaries ;).

Thanks for the heads-up on that. It's a no-go then.

Ah, finally found the comment from @pgaskin with a starting point Dockerfile. I knew he had posted it somewhere...

Might polish it up, chuck it on Github, and push an image to Docker Hub, or the new Github container registry perhaps.

pgaskin commented 3 years ago

This is pretty simple to do no matter which approach you take, although adding Go to an existing image will probably be the shortest.

or the new Github container registry perhaps

The main issue with that one is it wants authentication to pull images.

shermp commented 3 years ago

The main issue with that one is it wants authentication to pull images.

Really? From what I've read, that applies to GitHub packages. However, from what I've read, the container registry that was recently announced allows public images to be pulled anonymously.

pgaskin commented 3 years ago

Oh, that's new. I'll probably switch most references to NickelTC to it then.