search

shermp / NickelClock

Show time while reading on Kobo ereaders.
MIT License
158 stars 4 forks source link

Refactor, and set margins using stylesheet #5

Closed shermp closed 2 years ago

shermp commented 2 years ago

This PR refactors most of the code into a QObject derived class. This allows for interaction with Qt signals, slots and events.

ReadingFooter margins are now set by replacing the original stylesheet, instead of programmatically setting them. This should fix #2 although it's arguably a bit uglier. There should be less corner cases using this method however.

@pgaskin do you think this is a better approach compared to the previous PR?

shermp commented 2 years ago

Reports from Mobileread indicate this resolves the issue.

If needed, this can be refined in the future.