search

shermp / NickelDBus

Monitor and control kobo Nickel via dbus
MIT License
27 stars 2 forks source link

[WIP][RFC] Advanced confirmation dialogs #11

Closed shermp closed 3 years ago

shermp commented 3 years ago

This is a rather early WIP PR to get some feedback on this.

First, this PR includes all the changes from #10 so will supersede it.

As well as a TextLineEdit dialog from the previous PR, I'm also implementing an 'advanced' dialog option. This allows the developer to create a blank dialog, and populate it with an arbitrary number of widgets (from a select list of available widgets). When the user presses the accept button, a JSON representation of the widget state is emitted.

One use-case for this might be to create a poor-man's settings dialog for example.

I've basically got the barebones working now. It is far from done... Here are a few things that need working on:

If anyone has any queries/concerns/suggestions about this PR and the direction it's heading in, please let me know! A part of me is worried this is verging on scope creep.

shermp commented 3 years ago

Having a quick look at ConfirmationDialog.qss it looks like I won't be able to (easily) use it for styling the custom widgets, as it uses very specific selectors based on object names 😞

I need to look more into the QSS system, but maybe I can create my own stylesheet based on the existing ConfirmationDialog.qss that I can apply to the content frame?

pgaskin commented 3 years ago

You could find/replace before applying it.

shermp commented 3 years ago

Have removed the advanced dialogs functionality after sitting on it for a while.

Decided it was trying to do too much.

Will close this in favor of a new PR soon. (I've got an idea on how to make existing confirmation dialogs more flexible, which I want to try out first).