search

shermp / go-fbink-v2

Go FBInk wrapper, Vers. 2
GNU Affero General Public License v3.0
13 stars 2 forks source link

Update to FBInk 1.19.0 #5

Closed NiLuJe closed 5 years ago

NiLuJe commented 5 years ago

Like the last time, fbink_get_last_rect isn't implemented, but the structs skeletons are there ;).

shermp commented 5 years ago

Hey, thanks for this.

From a first glance, it looks ok, but I'm not able to test atm, as I'm currently in the US on holiday.

The merge may have to wait a couple of weeks until I get home.

NiLuJe commented 5 years ago

No worries, enjoy your holidays ;).

NiLuJe commented 5 years ago

Now includes a free update to FBInk 1.18.0 ;).

NiLuJe commented 5 years ago

Make that 1.18.1 ;).

shermp commented 5 years ago

I really do need to get around to merging this don't I?

Thanks for the updates!

NiLuJe commented 5 years ago

And now 1.19.0... ;p.

shermp commented 5 years ago

Sorry, missed the email on this (due to the great 2019 DNS oopsie - err.. incident)

From a quick look, seems alright. I'm just gonna merge this as-is.

Thanks.

As an aside, I'm thinking about using https://github.com/xlab/c-for-go in the future to automate binding creation.

NiLuJe commented 5 years ago

Ooh, that's a tiny bit fancier than what we're using for Lua/Python ;).

shermp commented 5 years ago

Yeah, I discovered it when I was looking at GUI toolkits for Go. https://github.com/golang-ui/nuklear uses it.