Require enum34 backport for python less than 3.4

sherpa-ai / sherpa

Hyperparameter optimization that enables researchers to experiment, visualize, and scale quickly.

http://parameter-sherpa.readthedocs.io/

GNU General Public License v3.0

331 stars 53 forks source link

Require enum34 backport for python less than 3.4 #102

Closed mcgibbon closed 4 years ago

mcgibbon commented 4 years ago

enum34 is "The enum module from Python3.4 backported from 3.3 - 2.4", from its description. The setup.py currently adds this as a requirement for greater versions, instead of lesser versions. This caused an issue with my environment where, on python 3.6+, I need to use a package which cannot install if enum34 is installed.

This PR changes the requirement to occur only on python versions below 3.4, instead of python versions above 3.4.

mcgibbon commented 4 years ago

See this StackOverflow question for someone with a similar situation (I get the same error).

LarsHH commented 4 years ago

Hi @mcgibbon ! Thanks for this fix. It is sometimes late at night that I get to work on the issues so my apologies for the mistake :)

tpanza commented 3 years ago

@LarsHH could you please publish a new release with this fix to the PyPI?