Using shlex to split runner_command

sherpa-ai / sherpa

Hyperparameter optimization that enables researchers to experiment, visualize, and scale quickly.

http://parameter-sherpa.readthedocs.io/

GNU General Public License v3.0

331 stars 53 forks source link

Using shlex to split runner_command #90

Closed nasimrahaman closed 4 years ago

nasimrahaman commented 4 years ago

First things first, great work on the library! 👍

This (very minor) issue is regarding this line, where I believe shlex.split(command) would be more appropriate (instead of command.split(' ') (shlex is a builtin module). It would enable commands like --arg1 "Argument 1" --arg2 "Argument 2". It would also be nice if command could be a pre-parsed list.

LarsHH commented 4 years ago

Resolved in #95