search

sherpya / geolite2legacy

MaxMind GeoLite2 (CSV) to Legacy format converter
MIT License
254 stars 88 forks source link

Province of City is always wrong -- Only in belgium .. #25

Open egnappahz opened 4 years ago

egnappahz commented 4 years ago

Dont know if I'm doing something wrong but everything is correct except the Province of the city. Is this an issue observed by others aswel?

egnappahz commented 4 years ago

Nevermind, only seems to be the case in Belgium so it seems. No idea why though. Guess it's kinda like our government.

egnappahz commented 4 years ago

Update: in your file geoname2fips.py you write

VLAMMS BRABANT': 'FLANDERS'

But It's supposed to be VLAAMS BRABANT.

However I cant seem to make it write a fips csv from it (absolutely clueless what parameters it is accepting) so I can't test if that fixed worked or not...

Indeed, all the flemish cities are being marked as being in flemish brabant, fixing that to flanders would indeed fix it.

Can anyone help?

egnappahz commented 4 years ago

I found out the problem. Please take a look at following pull request: https://github.com/sherpya/geolite2legacy/pull/26

I now have all the provinces working instead of just the general region (which was wrong and fixed on a single province for all cities)

sherpya commented 4 years ago

this is fixed but I need to generate new csv, did you modified it by hand? perhaps it needs to be converted in python module

egnappahz commented 4 years ago

I generated it with a bash script, I couldn't get the python module to work properly. I simply took a look of the geolite's extracted location file for the used BE provnames and at the fips 10-4 province id's and then generated the csv with all the correct ids for all BE cities, and replaced it with all the wrong be entries. I'll leave it to you to decide what to do in the python code...