search

shershen08 / vue-masonry

💠 Vue.js directive for masonry blocks layouting ✅
MIT License
674 stars 81 forks source link

Update dependancies #80

Closed crutchcorn closed 5 years ago

crutchcorn commented 5 years ago

This merge requests updates to babel@8, webpack@4, eslint@5

shershen08 commented 5 years ago

Thanks for PR @crutchcorn I'll check that today and get back with the feedback

crutchcorn commented 5 years ago

Two questions I had (that might be potentially out-of-scope for this PR: 1) Should the project build both files with one command? It does not do so currently 2) Is there a need/want for pushing dist to the repo. There is a postinstall hook for npm and yarn that could handle the build when the user npm install/yarn installs. I understand there seems to be wanted bower support, but I know their site defers to yarn for the front-end

shershen08 commented 5 years ago

@crutchcorn about 2nd part of your question

Is there a need/want for pushing dist to the repo

I've added /dist to a repo to be able to access it directly in browser environment - https://github.com/shershen08/vue-masonry#usage-directly-in-the-browser

shershen08 commented 5 years ago

about

Should the project build both files with one command? It does not do so currently

true, there was no need in this, since it's just a plugin library - I am not developing/building it on daily basis

crutchcorn commented 5 years ago

@shershen08 unkpg uses npm to get the files. You could still build dist for the npm package, but then not host the build on GitHub. Minor argument that doesn't matter too much either way, just a thought 🤷‍♀️

crutchcorn commented 5 years ago

I get not needing to build it regularly. I'm just very lazy for my own libraries and am easily forgetful about the build steps myself 😅

crutchcorn commented 5 years ago

@shershen08 was there more feedback for this PR or do you think it should be ready to go?